Repository navigation
fix(makefile): use python3 so make targets work on modern systems - #9
Merged
Merged
Conversation
The Makefile invoked 'python', which does not exist on macOS and many Linux setups (only 'python3' is on PATH), causing make seed/trigger/ verify/test to fail with 'python: No such file or directory'. Add a PYTHON ?= python3 variable (overridable) and use it in all targets. Verified against a live deploy in us-west-2.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Makefile invoked
python, which is not on PATH on modern macOS and many Linux setups (onlypython3exists), somake seed,make trigger,make verify, andmake testfailed withpython: No such file or directory.This adds a
PYTHON ?= python3variable (overridable, e.g.make PYTHON=python seed) and uses$(PYTHON)in all targets.Found and verified during a live end-to-end deploy in us-west-2 (deploy → seed → trigger → verify → destroy all succeeded after this fix).