Repository navigation
Add workflow-canvas scaffold: Vite, React, Cloudscape, CI - #77
Merged
Merged
Conversation
8 of 9 tasks
10 tasks done
knihit
marked this pull request as ready for review
October 24, 2026 04:36
knihit
requested review from
georgebearden,
ihmaws,
shsenior and
simonkrol
as code owners
October 24, 2026 04:36
7 of 11 tasks
ihmaws
approved these changes
Oct 27, 2026
Node 24 is the newest LTS line every dependency supports (jsdom needs ^24.15, vitest ^24 or >=26, eslint >=24). Set engines.node, @types/node and CI to it via .nvmrc. All other direct dependencies were already at their latest stable release; TypeScript stays on 6.0.x because typescript-eslint 8.72 requires <6.1.0.
Trigger on root .prettierrc changes, skip install scripts, drop the checkout credential, cap the job at 10 minutes and cancel superseded runs.
src/ no longer sees Node globals; only vite.config.ts is checked against @types/node via tsconfig.node.json. Drop Vite build options that equal the defaults, and let build rely on the separate typecheck step.
Wrap the page in AppLayout so it has a main landmark, label the tabs, and show a short placeholder in each tab panel.
…html - Apply the strict ESLint rules to every TS/TSX file in workflow-canvas/, so later folders need no extra config block. - Set the TypeScript target to ES2023 to match lib. - Add the SPDX license line to index.html.
knihit
force-pushed
the
wc/01-scaffold
branch
from
October 27, 2026 18:50
ec0c530 to
6f9e400
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
workflow-canvas/:
workflow-canvas/, an independent npm project (Vite, React, TypeScript) on Node 24 LTS or 26 (.nvmrcselects 24 until 26 becomes LTS on 2026-10-28;engines.node^24.15.0 || >=26, enforced byengine-strict=truein.npmrc) with exact-pinned dependencies (.npmrcsetssave-exact=true) and public@cloudscape-design/componentsand@cloudscape-design/global-stylesfrom npm. Onepackage.jsonis the only one for the folder, so the UI and later additions share it.AppLayout(gives the page amainlandmark) with a "Workflow canvas" heading and Designer and Execution tabs, each showing a short placeholder. This is the base the follow-up PRs build on.mainlandmark, both tabs (Designer selected) and the placeholders.workflow-canvas/README.md: short explanation of the folder layout and commands..prettierrc.CI:
.github/workflows/workflow-canvas.yml: runs lint, typecheck, test and build inworkflow-canvas/on PRs targetingmain,integration/**andwc/**(stacked PRs target other feature branches). Path-filtered toworkflow-canvas/**and the root.prettierrc,permissions: contents: read, actions pinned by SHA with a version comment (checkout v7.0.1, setup-node v7.1.0; the other workflows are untouched). The job runs as a matrix on Node 24 and 26; installs usenpm ci --ignore-scripts; checkout does not persist credentials; the job has a 10 minute timeout and superseded runs are cancelled. It is in a separate commit.Docs:
CHANGELOG.md: added an entry under Unreleased.VERSIONis not bumped.AGENTS.md: addedworkflow-canvas/to Project Structure, and the HTML form of the SPDX header (<!-- SPDX-License-Identifier: Apache-2.0 -->) to the license header list.Type of Change
package.json,Cargo.toml, or CLI dependency)workflow-canvas/folder (scaffold only)Testing
npm testpasses (runstests/scripts/**/*.test.js). The same 17 tests fail with and without this change in my environment, so they are unrelated to it.workflow-canvas/:npm run lint,npm run typecheck,npm testandnpm run buildpass locallyChecklist
vite buildprints Vite's "chunks are larger than 500 kB" warning (the JavaScript chunk is about 782 kB, mostly Cloudscape). I left the limit as it is so later growth stays visible; code splitting is deferred to a later MVP.Notes for Reviewers
integration/workflow-canvas; later PRs targetwc/*branches and are retargeted as lower PRs merge.typescript-eslint8.72 requires TypeScript<6.1.0, so 7.x waits for a new typescript-eslint release.src/is type-checked without Node types;tsconfig.node.jsoncoversvite.config.ts.workflow-canvas/package-lock.jsonis about 3,500 lines of the diff; the rest is about 340 lines.