Repository navigation
Conversation
PR CI ran the Rust tests but never clippy or rustfmt, so four mcp test files drifted from rustfmt's output. Format them, install the clippy and rustfmt components, and run make lint for cli, mcp and shared.
knihit
marked this pull request as ready for review
October 25, 2026 18:13
knihit
requested review from
georgebearden,
ihmaws,
shsenior and
simonkrol
as code owners
October 25, 2026 18:13
# Conflicts: # CHANGELOG.md
A floating stable toolchain lets each Rust release add clippy lints that -D warnings turns into failures on every PR. Pin 1.98.1 (lint passes on it) and bump it on purpose. The lint step now runs the root make lint, so a crate added there is linted in CI too.
… Added Move the make lint step to the end of the PR validation job so a lint failure no longer skips the claude CLI install, the plugin check, or the tarball check. Restore the "# stable" ref comment on the pinned rust-toolchain action, matching release.yml. List the new PR lint check under Added in the Unreleased CHANGELOG section.
The job-wide 1.98.1 pin also moved PR builds and tests off the stable toolchain that release.yml ships with. The setup step now installs floating stable again, matching release.yml, and drops the clippy and rustfmt components since only the lint step uses them. The lint step installs 1.98.1 with clippy and rustfmt and runs make lint CARGO="cargo +1.98.1", so only lint stays pinned.
The lint step reads the pinned version from RUST_LINT_TOOLCHAIN instead of repeating 1.98.1 in two commands.
…t, and tie the doc to the pin The pre-PR check now installs the toolchain with clippy and rustfmt first. The workflow comment says to update contributing.md when the pin moves.
# Conflicts: # docs/index.html # docs/site/.user-guide.manifest # docs/site/user-guide.html
…TOOLCHAIN check-guide-facts.py now reads the pin from validate-pr.yml and fails if contributing.md or either HTML bundle names a different version.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
CI:
validate-pr.ymlruns the rootmake lint, which lintscli,mcpandshared(clippy with-D warnings, thencargo fmt --check), so a crate added there is linted in CI too. PR CI ran the Rust tests but never linted them, so formatting drift went unnoticed.clippyandrustfmtand runsmake lint CARGO="cargo +$RUST_LINT_TOOLCHAIN". On floating stable, each Rust release could add clippy lints that-D warningsturns into failures on every PR. Builds and tests stay on floating stable, the toolchainrelease.ymlships with, so a stable-only break still shows up in PR CI. A rootrust-toolchain.tomlwas not used, because it would also pin release builds and every contributor's local cargo. BumpRUST_LINT_TOOLCHAINdeliberately.Formatting:
cargo fmton fourmcp/servers/skill-lookup/tests/files that had drifted from rustfmt's output:find_skills_shakedown.rs,full_tool_surface.rs,get_skill_shakedown.rsandhandshake_shakedown.rs. Line wrapping only.CHANGELOG: one bullet in a new
### Addedsection under[Unreleased].Docs:
appendix/contributing.md(and both HTML bundles) givemake lint CARGO="cargo +1.98.1"as the pre-PR check, so a local run matches CI's lint toolchain.Type of Change
Testing
make lintpasses on Rust 1.98.1 (RUSTUP_TOOLCHAIN=1.98.1). Before the formatting change,make -C mcp lintfailed on those four files.make -C mcp test-rustpasses after formatting.npm test: not affectedcd cli && make test: nocli/changesChecklist
Notes for Reviewers
docs/site/.user-guide.manifestis re-recorded becausecontributing.mdchanged, andbuild-user-guide.sh --checkhashes the Markdown tree. It does not hide anything new:mainalready records the current Markdown hash and its--checkpasses, while both bundles onmainstill lack theinstall-kiro-powerandinstall-claude-plugin-marketplacepages. Getting those pages into the bundles needs a full guide rebuild, which belongs in its own PR.make guide-checknow compares the lint toolchain named in the guide and both bundles withRUST_LINT_TOOLCHAIN.