Open
Conversation
- Upgrade aws-cdk-lib to ^2.240.0 which now uses minimatch ^10.2.1 natively (no longer bundled), fixing GHSA-3ppc-4f35-3m26 - Upgrade @aws-cdk/toolkit-lib to ^1.16.0 which drops archiver dependency chain - Add minimatch override to 10.2.1 for remaining transitive deps (eslint, typescript-eslint, eslint-plugin-import, eslint-plugin-react, prettier-plugin-sort-imports) - Update ajv 6.12.6 -> 6.14.0 via npm audit fix (GHSA-2g4f-4pwh-qvx6) npm audit now reports 0 vulnerabilities.
94d5d2c to
9b365f4
Compare
Contributor
Coverage Report
|
notgitika
approved these changes
Feb 24, 2026
Contributor
notgitika
left a comment
There was a problem hiding this comment.
I don't know if we need the override but I'm fine with it for now.
LGTM otherwise
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
aws-cdk-libto^2.240.0— now usesminimatch@^10.2.1natively and is no longer bundled, resolving GHSA-3ppc-4f35-3m26 for CDK@aws-cdk/toolkit-libto^1.16.0— drops thearchiverdependency chain (which pulled in vulnerable minimatch viaglobandreaddir-glob)minimatchoverride to10.2.1for remaining transitive deps (eslint, typescript-eslint, eslint-plugin-import, eslint-plugin-react, prettier-plugin-sort-imports)ajv6.12.6 → 6.14.0 vianpm audit fix(GHSA-2g4f-4pwh-qvx6) — v6 patch is now availableBefore: 16 vulnerabilities (1 moderate, 15 high)
After: 0 vulnerabilities;
npm run security:auditpassesTest plan
npm auditreports 0 vulnerabilitiesnpm run security:auditpassesnpm run lintpassesnpm run buildpassesnpm test— all 1,754 unit tests pass