feat: skip MCP client generation for VPC agents#450
Open
Conversation
VPC agents may not have public internet access, so Exa AI MCP server should not be included in generated code. Adds isVpc flag to template rendering and conditionally excludes mcp_client/ directory and MCP imports in main.py for all frameworks.
tejaskash
requested a deployment
to
e2e-testing
GitHub Actions
Waiting
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
| from autogen_core.tools import FunctionTool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
| from langchain.tools import tool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
| from agents import Agent, Runner, function_tool | ||
| from bedrock_agentcore.runtime import BedrockAgentCoreApp | ||
| from model.load import load_model | ||
| {{#unless isVpc}} |
Contributor
Coverage Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isVpcflag toAgentRenderConfigand template rendering pipelinemcp_client/directory rendering when agent uses VPC network mode (viaskipDirsincopyAndRenderDir){{#unless isVpc}}Handlebars conditionals in all 5 frameworkmain.pytemplates (Strands, LangChain, GoogleADK, OpenAIAgents, AutoGen)Test plan
npm run buildcompilesnpm testpasses (snapshot tests updated)mcp_client/absent,main.pyhas no MCP importsmcp_client/present,main.pyhas MCP imports