Add support for configuring EFA receiver on EC2 via JSON#2093
Open
mitali-salvi wants to merge 3 commits intomainfrom
Open
Add support for configuring EFA receiver on EC2 via JSON#2093mitali-salvi wants to merge 3 commits intomainfrom
mitali-salvi wants to merge 3 commits intomainfrom
Conversation
Add a new translator that converts CloudWatch Agent JSON config to OTel YAML config for the awsefareceiver. Customers can configure EFA metrics collection under metrics.metrics_collected.efa with optional measurement filtering and collection interval overrides. The translator follows the existing awsnvme translator pattern: - Reads from metrics::metrics_collected::efa config path - Supports collection_interval with agent-level fallback (default 60s) - Supports measurement filtering with efa_ prefix auto-detection - Validates metric names against the 22 known EFA metrics - Disables unselected metrics when measurement list is specified Assisted-by: Kiro CLI
Register the EFA receiver in the host delta metrics pipeline alongside diskio and net receivers. Add EFA as a recognized native OTel receiver in the adapter layer and include efaKey in the cumulativetodelta processor's default keys so EFA alone satisfies the delta pipeline requirement. Assisted-by: Kiro CLI
Add efaDefinitions to the JSON schema under metrics_collected. Unlike other receivers, measurement is optional for EFA - an empty config enables all 22 metrics by default. Assisted-by: Kiro CLI
e6c81b3 to
df22c22
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue
Add support for configuring the awsefareceiver via the CWA JSON configuration. Customers will be able to configure EFA (Elastic Fabric Adapter) metrics collection under metrics.metrics_collected.efa.
EFA is a distinct hardware type (Elastic Fabric Adapter) that exposes 22 cumulative monotonic sum
metrics via
/sys/class/infiniband/sysfs.Collect all 22 EFA metrics with defaults:
Collect specific metrics with a custom interval and selected metrics:
License
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tests
enabled instances, confirmed agent starts and collects metrics
Requirements
Before commiting your code, please do the following steps.
make fmtandmake fmt-shmake lintIntegration Tests
To run integration tests against this PR, add the
ready for testinglabel.