This repository was archived by the owner on Sep 13, 2024. It is now read-only.
Open
Conversation
+ Uses rpm to track the bundled dependencies
+ Update the service file to be on par with the generic-rpm and get the
environment setting into the systemd execution environment to support
ECS Anywhere
samuelkarp
reviewed
May 26, 2021
| BuildRequires: systemd | ||
| Requires: docker >= 1.6.0 | ||
| # Patch local to openSUSE Build service to get reproducible builds | ||
| #Patch0: reproducible.patch |
Contributor
There was a problem hiding this comment.
Is this patch something that can be upstreamed so that ecs-init builds reproducibly?
Contributor
There was a problem hiding this comment.
@rjschwei Is this something you can respond to?
Contributor
Author
|
And I just noticed I completely messed up the changes file, follow up push coming, sorry. Confused what we keep in the changes file and what is here and just copied the file. |
+ Add the current changes rather than clobbering the file with the one
maintained in the openSUSE Build Service
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
environment setting into the systemd execution environment to support
ECS Anywhere
Summary
Implementation details
environment setting into the systemd execution environment to support
ECS Anywhere
If you have included new dependencies, please ensure you have followed
Packaging guidance from
https://github.com/aws/amazon-ecs-init/blob/master/CONTRIBUTING.md
-->
Testing
Manual test for ECS Anywhere
New tests cover the changes:
Description for the changelog
Update the packaging data for SUSE
Licensing
This contribution is under the terms of the Apache 2.0 License: yes