Conversation
Contributor
|
Total lines changed 4012 is greater than 1000. Please consider breaking this PR down. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1301 +/- ##
=======================================
Coverage 88.19% 88.20%
=======================================
Files 73 73
Lines 10386 10386
Branches 1410 1409 -1
=======================================
+ Hits 9160 9161 +1
+ Misses 1199 1198 -1
Partials 27 27
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
rix0rrr
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Speeds up
deploy.test.tsanddiff.test.tsby eliminating ~34 redundant CDK app syntheses per test run.Each
builderFixturecall was running a full synthesis throughfromAssemblyBuilder, loadingaws-cdk-libmodules, creating temp directories, acquiring file locks, and resolving the default AWS environment. None of these tests actually test synthesis — they only care about the resulting CloudFormation templates and manifest metadata.All
builderFixturecalls are replaced withcdkOutFixture, which reads pre-builtcdk.outdirectories from disk viafromAssemblyDirectory. A newgen-fixtureprojen task and script (scripts/gen-fixture-cdk-out.ts) are added to generate and regenerate these fixtures usingToolkit.fromAssemblyBuilder, ensuring the output is identical to what the tests were previously synthesizing at runtime.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license