Open
Conversation
…LE_DEPRECATION_WARNINGS=ON
xiazhvera
reviewed
Aug 15, 2025
| option(BUILD_DEPS "Builds aws common runtime dependencies as part of build. Turn off if you want to control your dependency chain." ON) | ||
| option(USE_EXTERNAL_DEPS_SOURCES "Use dependencies provided by add_subdirectory command" OFF) | ||
| option(BUILD_SAMPLES "(DEPRECATED) Build samples as part of the build" OFF) | ||
| option(AWS_CRT_DISABLE_DEPRECATION_WARNINGS "Set this to silence [[deprecated]] warnings coming from aws-crt-cpp headers" OFF) |
Contributor
There was a problem hiding this comment.
Would the deprecation note affect current V1 service client user?
Contributor
Author
There was a problem hiding this comment.
It will notify anyone using the MQTT3 client and connections that it's deprecated. Toggling this to ON should turn those warnings off even for V1 service client users.
xiazhvera
approved these changes
Sep 29, 2025
sfod
reviewed
Oct 2, 2025
Comment on lines
-34
to
+35
| * Name of the IoT Thing that you want to subscribe to DescribeJobExecution response events for. | ||
| * Name of the IoT Thing that you want to subscribe to DescribeJobExecution | ||
| * response events for. |
Contributor
There was a problem hiding this comment.
These are strange changes, like from misconfigured clang-format
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.