register stack for cleanup in test_sync_infra_s3_bucket_option#8682
Open
register stack for cleanup in test_sync_infra_s3_bucket_option#8682
Conversation
reedham-aws
reviewed
Feb 23, 2026
Contributor
reedham-aws
left a comment
reedham-aws
left a comment
There was a problem hiding this comment.
Code change looks small, but could you add more description as to what's happening? I don't really follow what this one-line change is going to fix.
valerena
approved these changes
Feb 23, 2026
reedham-aws
approved these changes
Feb 23, 2026
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Contributor
|
Once #8687 gets merged we need to merge it here because that's what contains the fix for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Cleaning API GW resource after test
Why is this change necessary?
The
test_sync_infra_s3_bucket_optiontest method creates a CloudFormation stack but doesn't register it for cleanup intearDown(). This causes the stack and its resources (including HTTP API Gateways) to be orphaned when the test completes.How does it address the issue?
Adds the missing
self.stacks.append({"name": stack_name})line after the stack name is generated. This registers the stack for immediate cleanup intearDown(), matching the pattern used in other test methods liketest_sync_infra. Now the stack will be deleted immediately after the test completes, regardless of pass/fail status.What side effects does this change have?
None. This aligns the cleanup behavior with all other sync integration tests. The stack will be deleted faster (immediately in
tearDown()instead of waiting for the account reset Lambda), reducing the window for security scanners to detect orphaned resources.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.