test: add integration tests for CLI client#8689
Open
reedham-aws wants to merge 2 commits intoaws:feat-buildkitfrom
Open
test: add integration tests for CLI client#8689reedham-aws wants to merge 2 commits intoaws:feat-buildkitfrom
reedham-aws wants to merge 2 commits intoaws:feat-buildkitfrom
Conversation
github-actions
bot
added
area/local/start-api
Member
|
prob need to merge from develop for the chardet thing |
reedham-aws
force-pushed
the
buildkit-tests-integ
branch
from
1d13e88 to
c4155ec
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration test PR for buildkit/container CLI support.
Added a few parameterized tests for some image based tests, as well as just general tests for using the
--use-buildkitflag. Worth noting is that when using the CLI, there were a lot of resource warnings that the sockets were being left open. I couldn't figure out a fix to this, but I think they're harmless warnings so I ignored them.Implementation PR: #8661.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.