Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 92.30% 92.53% +0.22%
==========================================
Files 15 15
Lines 2626 2826 +200
Branches 2626 2826 +200
==========================================
+ Hits 2424 2615 +191
- Misses 152 160 +8
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: Simon Marty <martysi@amazon.com>
de875e6 to
cde666a
Compare
| #[tokio::test] | ||
| async fn test_is_current_default_succeeds() { | ||
| let client = fake_client(Some(Duration::from_secs(0)), false, None, None); | ||
| async fn test_get_cache_is_current_fast_refreshes() { |
There was a problem hiding this comment.
The is_current tests (test_get_cache_is_current_fast_refreshes, test_is_current_version_id_succeeds, test_is_current_version_stage_succeeds, test_is_current_both_version_id_and_version_stage_succeed) share ~90% identical setup: same GSV mock, same describe mock, same client construction, same assertion loop. A helper that takes optional version_id/version_stage and returns a configured client + mock rules would cut a lot of duplication. The old code had fake_client() for this, looks like we removed it for mock-based tests but didn't replace it.
Signed-off-by: Simon Marty <martysi@amazon.com>
Issue #, if available:
Description of changes: Accidentally closed #112 on a force push.
Move unit tests to aws-smithy-mocks for easier test coverage.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.