Conversation
…nt hook and interval-based periodical flush
jariy17
approved these changes
Mar 3, 2026
Contributor
jariy17
left a comment
jariy17
left a comment
There was a problem hiding this comment.
Good. Just add nit that would reduce code complexity
| pending = self.pending_message_count() | ||
| if pending > 0: | ||
| logger.debug("Interval flush triggered: %d message(s) pending", pending) | ||
| self._flush_messages() |
Contributor
There was a problem hiding this comment.
nit: __flush_messages will return early if the buffer is empty. Therefore, we don't need to precheck the buffer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
Add automatic flush mechanisms for batched messages
Add two automatic flush mechanisms to AgentCoreMemorySessionManager
to ensure messages are persisted without manual intervention:
AfterInvocationEvent hook: Automatically flushes buffered messages after agent invocation completes. Only registered when batching is enabled (batch_size > 1) to avoid unnecessary overhead.
Interval-based flush: Periodically flushes messages at configurable intervals for long-running agents. Controlled by new optional flush_interval_seconds config parameter (default: None/disabled).
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.