Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sagemaker-serve/src/sagemaker/serve/model_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -463,8 +463,9 @@ def _initialize_compute_config(self) -> None:
def _initialize_network_config(self) -> None:
"""Initialize network configuration from Networking object."""
if self.network:
if self.network.vpc_config:
self.vpc_config = self.network.vpc_config
vpc_config = getattr(self.network, "vpc_config", None)
if vpc_config:
self.vpc_config = vpc_config
else:
self.vpc_config = (
{
Expand Down
23 changes: 23 additions & 0 deletions sagemaker-serve/tests/unit/test_model_builder_missing_coverage.py
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,29 @@ def test_initialize_network_config_with_subnets(self):
assert builder.vpc_config is not None
assert "Subnets" in builder.vpc_config

def test_initialize_network_config_with_real_networking_object(self):
"""Test _initialize_network_config with Networking from sagemaker-core."""
from sagemaker.core.training.configs import Networking

network = Networking(
subnets=["subnet-123"],
security_group_ids=["sg-456"],
enable_network_isolation=True,
)

builder = ModelBuilder(
model=Mock(),
network=network,
role_arn="arn:aws:iam::123456789012:role/test",
sagemaker_session=self.mock_session,
)

assert builder.vpc_config == {
"Subnets": ["subnet-123"],
"SecurityGroupIds": ["sg-456"],
}
assert builder._enable_network_isolation is True

def test_initialize_defaults_region_from_boto3(self):
"""Test _initialize_defaults region fallback to boto3 (lines 472-476)."""
with patch('boto3.Session') as mock_boto_session:
Expand Down
Loading