Fixed vllm and vllm-omni tasks to correct routing logic for HF DLCs - #6007
Conversation
| } | ||
|
|
||
| # HuggingFace pipeline tags for models that can generate multiple output modalities. | ||
| OMNI_TASKS: Set[str] = { |
There was a problem hiding this comment.
is it always true?
many any-to-any run on vllm, no? https://recipes.vllm.ai/Google/gemma-4-12B-it
There was a problem hiding this comment.
iiuc, not all models on the hub flagged as any-to-any would work on vllm. In fact, also gemma-4-12B-it has a dedicated vllm image to make it work vllm/vllm-openai:gemma4-unified
732d75e to
ee08d99
Compare
Signed-off-by: DWarez <dario.salvati@huggingface.co>
714a2bb to
7da2ff9
Compare
|
@rsareddy0329 in the current routing logic, tasks that should be handled with vllm (like image-text-to-text) are instead routed to vllm-omni, which results in the wrong resolution of the image uri when using the ModelBuilder abstraction. We'd like to leave only the any-to-any task to be run in vllm-omni for the moment, and even with this logic there are edge cases (like google/gemma-4-12B-it which is flagged as any-to-any but should be served with vllm) |
|
Claude finished @dwarez's task in 1m 9s —— View job Code Review
I reviewed the routing change. Overall this is a clean, well-scoped fix. The core insight is correct: Correctness / consistency ✅
Tests ✅
Points worth confirming (not blockers):
No security or performance concerns — this is a constant/set change plus routing dispatch. LGTM pending the Note: the inline-comment tool isn't available in this run, so the file/line references are inlined above. |
Previously, the set of vLLM and vLLM-omni tasks used in routing for Hugging Face DLCs was wrong, which resulted in the wrong DLCs selection for models like
google/gemma-4-E2B-itand otherimage-text-to-textmodels.