Skip to content

add: metadata for hf-vllm 0.22.1, 0.25.1, 0.26, 0.27.1 and 0.28 - #6060

Open
dwarez wants to merge 9 commits into
aws:masterfrom
huggingface:hf/vllm-metadata
Open

add: metadata for hf-vllm 0.22.1, 0.25.1, 0.26, 0.27.1 and 0.28#6060
dwarez wants to merge 9 commits into
aws:masterfrom
huggingface:hf/vllm-metadata

Conversation

@dwarez

@dwarez dwarez commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Description of changes:
Updating metadata for huggingface-vllm

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

Signed-off-by: DWarez <dario.salvati@huggingface.co>
Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez dwarez changed the title add: metadata for hf-vllm 0.22.1 and 0.25.0 add: metadata for hf-vllm 0.22.1 and 0.25.1 Jul 27, 2026
@dwarez
dwarez marked this pull request as draft July 30, 2026 15:25
Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez
dwarez marked this pull request as ready for review August 6, 2026 12:54
@dwarez dwarez changed the title add: metadata for hf-vllm 0.22.1 and 0.25.1 add: metadata for hf-vllm 0.22.1, 0.25.1 and 0.26 Aug 6, 2026
Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez dwarez changed the title add: metadata for hf-vllm 0.22.1, 0.25.1 and 0.26 add: metadata for hf-vllm 0.22.1, 0.25.1, 0.26 and 0.27.1 Aug 19, 2026
Signed-off-by: DWarez <dario.salvati@huggingface.co>
@dwarez
dwarez deployed to manual-approval August 28, 2026 08:47 — with GitHub Actions Active
@dwarez
dwarez deployed to manual-approval August 28, 2026 08:47 — with GitHub Actions Active
@dwarez
dwarez deployed to manual-approval August 28, 2026 08:48 — with GitHub Actions Active
@dwarez dwarez changed the title add: metadata for hf-vllm 0.22.1, 0.25.1, 0.26 and 0.27.1 add: metadata for hf-vllm 0.22.1, 0.25.1, 0.26, 0.27.1 and 0.28 Aug 28, 2026
@github-actions

github-actions Bot commented Sep 11, 2026

Copy link
Copy Markdown

Claude finished @dwarez's task in 48s —— View job


PR Review: hf-vllm image URI metadata

  • Read PR diff and changed file
  • Verify JSON validity & structural consistency
  • Check version aliases and tag/container fields
  • Check for tests needing updates
  • Post review

Summary

This is a data-only change adding huggingface-vllm inference metadata for versions 0.22.1, 0.25.1, 0.26.0, 0.27.1, and 0.28.0 plus the matching version_aliases. I reviewed huggingface-vllm.json against the existing entries.

The change looks clean.

  • The file is valid JSON and parses cleanly.
  • Every new version block mirrors the established structure (py_versions, registries, tag_prefix, repository, container_version) — the registry account-ID maps are identical to the existing 0.14.0/0.17.0/0.21.0 entries.
  • version_aliases are internally consistent — each alias (0.22, 0.25, 0.26, 0.27, 0.28) points to a versions key that actually exists.
  • No unit tests reference huggingface-vllm specifically (the sagemaker-core/tests/unit/image_uris/ suite covers other frameworks), so no test update is required by this change.

Minor notes (non-blocking)

  • PR title drift: the title says "0.22.1, 0.25.1, 0.26 and 0.27.1" but the diff also adds 0.28.0 (added in a later commit). Worth updating the title/description for the changelog's sake.
  • 0.28.0 differs from the others — it uses tag_prefix: "0.28.0-transformers5.15.0" and container_version.gpu: "cu130-ubuntu24.04-v1.0" (ubuntu24.04 + a -v1.0 suffix), whereas 0.22.1–0.27.1 use transformers5.10.2 / cu130-ubuntu22.04. This is fine if it reflects the real published ECR tags — just flagging so it's a deliberate value, not a copy error. Please confirm the resulting tag ({tag_prefix}-gpu-{container_version}) matches the actual DLC image tag in ECR.

I can't independently verify the registry account IDs or that the ECR tags exist — those are data points only the DLC/maintainer side can confirm. Structurally everything is correct.

No security, correctness, or backward-compatibility concerns: this is purely additive and doesn't alter existing version entries.

@dwarez
dwarez deployed to manual-approval September 12, 2026 16:50 — with GitHub Actions Active
@dwarez
dwarez deployed to manual-approval September 12, 2026 16:50 — with GitHub Actions Active
@dwarez
dwarez deployed to manual-approval September 12, 2026 16:50 — with GitHub Actions Active
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Claude finished @dwarez's task in 53s —— View job


PR Review: hf-vllm image URI metadata

  • Read PR diff and changed file
  • Verify JSON validity & structural consistency
  • Check version aliases and tag/container fields
  • Check for tests needing updates
  • Post review

Summary

Data-only change adding huggingface-vllm inference metadata for 0.22.1, 0.25.1, 0.26.0, 0.27.1, and 0.28.0 plus matching version_aliases. Reviewed huggingface-vllm.json against the existing 0.14.0/0.17.0/0.21.0 entries.

The change looks clean. ✅ Purely additive, no existing entries modified — no correctness, security, or backward-compatibility concerns.

  • Valid JSON; parses cleanly.
  • Each new version block mirrors the established schema (py_versions, registries, tag_prefix, repository, container_version); the registry account-ID maps are identical to the existing entries.
  • version_aliases are internally consistent — every alias (0.220.22.1, 0.250.25.1, 0.260.26.0, 0.270.27.1, 0.280.28.0) resolves to a versions key that exists.
  • No unit tests reference huggingface-vllm (the sagemaker-core/tests/unit/image_uris/ suite covers other frameworks), so no test update is required.

Points to confirm (non-blocking, data I can't verify)

These are data values only the DLC/maintainer side can confirm — flagging so they're deliberate, not copy errors:

  1. 0.28.0 diverges from the others. It uses tag_prefix: "0.28.0-transformers5.15.0" and container_version.gpu: "cu130-ubuntu24.04-v1.0" (ubuntu 24.04 + a -v1.0 suffix), whereas 0.22.1–0.27.1 use transformers5.10.2 / cu130-ubuntu22.04. Please confirm the resulting tag ({tag_prefix}-gpu-{container_version}, i.e. 0.28.0-transformers5.15.0-gpu-cu130-ubuntu24.04-v1.0) matches the actual published ECR tag.

  2. Registry account IDs & ECR tag existence for all five versions — I can't independently verify these against ECR; they're identical to the existing entries, which is a good sign.

Minor note

  • PR title drift: the title lists 0.22.1, 0.25.1, 0.26, 0.27.1 and 0.28 which now matches, but the body still says only "huggingface-vllm" generically — worth listing the versions there for the changelog.

Structurally everything is correct; nothing blocking from the code side.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant