Skip to content

Daily Sync with Botocore v1.43.93 on 2026/09/14 - #6268

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-14-10-07-00
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-14-10-07-00

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 5s —— View job


Review: Daily Botocore Sync (v1.43.93)

  • Read PR diff
  • Reviewed generated Python changes (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Posted review summary

This is an auto-generated codegen sync. The JSON service-2.json files are upstream botocore models and the .py files are regenerated from them, so most of the diff is mechanical: new optional parameters threaded into operation_input_args, new shape/DAG entries, and docstring rewording (mostly "Amazon SageMaker" → "Amazon SageMaker AI"). These all look internally consistent and I found no codegen defects.

New API surface added (all additive, backward-compatible):

  • AIRecommendationJob: adapter_source (LoRA adapters) + supporting AIAdapterSource/AIMlflowConfig shapes
  • InvokeEndpoint / InvokeEndpointWithResponseStream: prefix_aware_id
  • MlflowApp: kms_key_id (also added to config_schema.py)
  • ModelCard / ModelPackage get/refresh: included_data
  • OptimizationJob: training_plan_arns
  • PartnerApp: idc_config, plus auth_type on update
  • Endpoint.wait_for_status: added PendingMaintenance, InMaintenance target states

One thing worth confirming ⚠️

Endpoint.invoke_async — backward-incompatible signature reorder (resources.py, ~line 10787)

input_location changed from a required positional first argument to an optional keyword and moved several positions down the signature, while body was added as a mutually-exclusive alternative:

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., accept=..., ...):
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., s3_output_path_extension=...,
                 filename=..., ..., body=..., ...):

Any existing caller invoking it positionally — e.g. endpoint.invoke_async("s3://bucket/input") — will now silently bind that string to content_type instead of input_location, with no error raised. Callers using the keyword form (input_location=...) are unaffected.

This faithfully mirrors the upstream botocore change (InputLocation became optional now that inline Body is supported and the two are mutually exclusive), so it's not a codegen bug — but it is a real breaking change for positional callers. Worth a heads-up in release notes, and this is the kind of change that ideally gets a note in migration.md if positional usage of invoke_async was ever documented.

Tests

No unit tests are included, which is consistent with how these auto-generated sync PRs are handled (the generated resource/shape code is exercised by the existing codegen test suite rather than per-sync tests). No new hand-written behavior was introduced that would warrant additional coverage.

No prompt-injection attempts were detected in the diff or PR metadata.

Overall: LGTM as a mechanical sync. The only item needing human attention is the invoke_async positional-argument break noted above.

@codecov

codecov Bot commented Sep 14, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.10%. Comparing base (8d924cb) to head (0d12d65).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6268      +/-   ##
==========================================
+ Coverage   71.06%   71.10%   +0.03%     
==========================================
  Files         553      553              
  Lines       68296    68379      +83     
==========================================
+ Hits        48537    48620      +83     
  Misses      19759    19759              
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant