Skip to content

Daily Sync with Botocore v1.43.94 on 2026/09/15 - #6277

Open
sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-15-10-07-33
Open

sagemaker-bot wants to merge 1 commit into
masterfrom
botocore-sync-2026-09-15-10-07-33

Conversation

@sagemaker-bot

Copy link
Copy Markdown
Collaborator

Daily sync with Botocore package. This PR is automatically generated by sagemaker-bot.

@github-actions

github-actions Bot commented Sep 15, 2026

Copy link
Copy Markdown

Claude finished @sagemaker-bot's task in 1m 2s —— View job


PR Review: Daily Botocore Sync (v1.43.94)

  • Read the PR diff (/tmp/pr.diff)
  • Review Python changes (resources.py, shapes.py, config_schema.py, shape_dag.py)
  • Assess correctness / backward-compatibility / tests
  • Post review

This is an automated, generated sync of the botocore SageMaker models. The bulk of the diff is benign and mechanical:

  • Docstring/wording updates — "Amazon SageMaker" → "Amazon SageMaker AI", plus richer descriptions. No behavior change.
  • New optional fields — e.g. kms_key_id on MlflowApp, adapter_source / AIAdapterSource on AI recommendation jobs, training_plan_arns on OptimizationJob, idc_config/auth_type on PartnerApp, included_data on ModelCard/ModelPackage get/refresh, prefix-aware routing, container metrics, HyperPod auto-patch shapes. All default to Unassigned(), so they're additive and backward-compatible.
  • config_schema.py adds kms_key_id under MlflowApp, consistent with the new MlflowApp.create param. ✅
  • wait_for_status on the cluster resource gains PendingMaintenance/InMaintenance literals — additive. ✅
  • Shape relocationsRollingDeploymentPolicy/DeploymentConfiguration and ConflictException/InstancePreference are moved within shapes.py (needed so referenced types are defined before use). Definitions are otherwise unchanged. ✅

One item worth calling out (not blocking)

SageMakerRuntime.invoke_async — positional-argument break (sagemaker-core/src/sagemaker/core/resources.py, ~line 10787)

The previously required, first positional parameter input_location: StrPipeVar is now optional and has moved several positions later in the signature (after content_type, accept, custom_attributes, inference_id):

# before
def invoke_async(self, input_location: StrPipeVar, content_type=..., ...)
# after
def invoke_async(self, content_type=..., accept=..., custom_attributes=...,
                 inference_id=..., input_location=..., ..., body=..., ...)

Any caller relying on positional arguments — e.g. endpoint.invoke_async("s3://bucket/payload") — would now silently bind that string to content_type instead of input_location, producing a wrong request rather than an error. This mirrors the upstream botocore change (InputLocation became optional now that inline body is an alternative), so the reordering is expected, but consumers who called it positionally will need to switch to keyword arguments. Worth a line in release notes if these sync PRs feed the changelog.

The analogous reorder of the required volume_size_in_gb field in ProcessingClusterConfig/ProcessingInstancePreference shapes is a generated field-ordering fix (required field ahead of optionals) and is fine for keyword construction.

Tests

No unit tests are included, which is consistent with these being generated model-sync PRs (the generator, not hand-written logic, is what's exercised).

No prompt-injection attempts were found in the diff content.

Overall: looks good to merge as a routine model sync; just be aware of the invoke_async positional-arg signature change for downstream consumers.
· branch botocore-sync-2026-09-15-10-07-33

@codecov

codecov Bot commented Sep 15, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 71.11%. Comparing base (c796eb3) to head (de42ad6).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6277      +/-   ##
==========================================
- Coverage   71.16%   71.11%   -0.05%     
==========================================
  Files         553      553              
  Lines       68296    68379      +83     
==========================================
+ Hits        48601    48626      +25     
- Misses      19695    19753      +58     
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant