Draft
Conversation
rkeene
reviewed
Jan 13, 2022
Contributor
rkeene
left a comment
There was a problem hiding this comment.
Thanks @zqumei0 this is much faster !
One thing that I've noticed is that this can make too many queries per second to the AWS CodeCommit endpoint if you have a lot of open PRs.
What might be useful here is to limit the number of inflight API calls.
This can be done by collecting the background process IDs ("$!" after ) &) and once the list of those grows beyond a certain number, wait, clear the list, and continue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
N/A
Description of changes:
Parallelized for loop in prlist() responsible for making awscli calls and formatting pr lines decreasing runtime of prlist operation.
Runtime measurement below were measure as follows:
Runtime test output for sequential prlist():
Runtime test output for parallel prlist():
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.