Skip to content

Fix crash on Linux when testing the archive plugin #641

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebsto merged 2 commits into from
Feb 16, 2026
Merged

Fix crash on Linux when testing the archive plugin #641

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
00685b6
fix crash on Linux when testing the archive plugin
Feb 12, 2026
69bcec3
Merge branch 'main' into sebsto/fix_plugin
sebsto Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 9 additions & 6 deletions Plugins/AWSLambdaPackager/PluginUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,16 +92,19 @@ struct Utils {
if let customWorkingDirectory {
process.currentDirectoryURL = URL(fileURLWithPath: customWorkingDirectory.path())
}
process.terminationHandler = { _ in
outputQueue.async {
outputHandler(try? pipe.fileHandleForReading.readToEnd())
}
}

try process.run()
process.waitUntilExit()

// wait for output to be full processed
// Stop the readability handler before reading remaining data to avoid
// a race between the handler and readToEnd() on Linux, which can cause
// a SIGSEGV in the Swift runtime's metadata resolution.
pipe.fileHandleForReading.readabilityHandler = nil

// Read any remaining data from the pipe
outputQueue.async { outputHandler(try? pipe.fileHandleForReading.readToEnd()) }

// wait for output to be fully processed
outputSync.wait()
Comment on lines +104 to 108
Copy link

Copilot AI Feb 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

outputSync.wait() is not guaranteed to wait for the final outputQueue.async (or any pending readability-handler enqueues), because outputSync.enter() happens inside outputHandler after the async work has started. If wait() runs before the async block executes, the group count is still 0 and wait() can return early, causing truncated output and potential mutation of outputMutex after output is read. Move the DispatchGroup enter/leave to wrap each outputQueue.async submission (or drain the queue with outputQueue.sync {} / use outputQueue.sync for the final readToEnd).

Copilot uses AI. Check for mistakes.

let output = outputMutex.withLock { $0 }
Expand Down
Loading