Skip to content

Fix more crashes in archive #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sebsto merged 2 commits into from
Feb 17, 2026
Merged

Fix more crashes in archive #642

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a1845e7
attempt to fix more crashes in archive
Feb 16, 2026
2042488
fix a potential race condition
Feb 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 18 additions & 11 deletions Plugins/AWSLambdaPackager/PluginUtils.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,6 @@ struct Utils {
}

let pipe = Pipe()
pipe.fileHandleForReading.readabilityHandler = { fileHandle in
outputQueue.async { outputHandler(fileHandle.availableData) }
}

let process = Process()
process.standardOutput = pipe
Expand All @@ -93,17 +90,27 @@ struct Utils {
process.currentDirectoryURL = URL(fileURLWithPath: customWorkingDirectory.path())
}

// Read from the pipe on a background thread using a manual read loop.
// We avoid FileHandle.readabilityHandler because on Linux its setter
// triggers _bridgeAnythingToObjectiveC / swift_dynamicCast which can
// crash with a SIGSEGV during concurrent Swift runtime metadata resolution.
let readFileHandle = pipe.fileHandleForReading
outputSync.enter()
outputQueue.async {
defer { outputSync.leave() }
// Read in a loop until EOF
while true {
let data = readFileHandle.availableData
if data.isEmpty {
break // EOF
}
outputHandler(data)
}
}

try process.run()
process.waitUntilExit()

// Stop the readability handler before reading remaining data to avoid
// a race between the handler and readToEnd() on Linux, which can cause
// a SIGSEGV in the Swift runtime's metadata resolution.
pipe.fileHandleForReading.readabilityHandler = nil

// Read any remaining data from the pipe
outputQueue.async { outputHandler(try? pipe.fileHandleForReading.readToEnd()) }

// wait for output to be fully processed
outputSync.wait()

Expand Down