feat: Added support for apple container

[manojmahapatra]

Issue #

#644

Description of changes

• Added --container-cli option to the archive SwiftPM plugin so users can choose Docker (default) or Apple container
• Implemented Apple container support by switching pull/run commands to container image pull and container run
• Documented the Apple container path in readme.md
• swift test passed

New/existing dependencies impact assessment, if applicable

N/A

Conventional Commits

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[sebsto]

LGTM - I will test on my machine before merging :-)
One small nit on the README

[sebsto]

I filed a bug against SPM
swiftlang/swift-package-manager#9763

[sebsto]

Question: should we rename the function buildInDocker to something else ? buildInContainer ? (with the generic usage of the word container) - but this is confusing because it's also the name of the container CLI.

What do you think?

[manojmahapatra]

Question: should we rename the function buildInDocker to something else ? buildInContainer ? (with the generic usage of the word container) - but this is confusing because it's also the name of the container CLI.

What do you think?

That's good point. we can perhaps rename it something akin to buidInContainerEnvironment to make it sound like generic container based path? Plus the function is private, I'll be not worried too much.

[sebsto]

Plus the function is private, I'll be not worried too much.

Correct. That's something I can change in the new plugin implementation too

[sebsto]

Wow - the SPM fix is waiting to be merged. swiftlang/swift-package-manager#9764
But it won't land until a future Swift release.

[manojmahapatra]

Oh wow...that was super quick :)

[sebsto]

LGTM