Fix/docs route links - #3
Merged
Merged
Conversation
The site used to be a project site where the app owned "/" and a page was /expo-devtools/network. Moving to the organisation root put the docs tree under /docs, and the inline markdown links were updated but the Card hrefs were not, so every one of them 404s. Image paths stay at the root: those files are in public/, not in content.
NEXT_PUBLIC_SITE_URL is set nowhere, including the deploy workflow, so the fallback was doing the work and every published OG and Twitter image pointed at http://localhost:3000. A shared link previewed nothing. The site has had an origin since it moved to the organisation root, so that is the fallback now. The env var still overrides it for a preview deploy.
.turbo/ appears whenever this is built from the monorepo root, so it shows up as untracked content in the parent's status.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.