Repository navigation
gallery: feature golang/go; a failed replay is named, not 'no commits' - #11
Merged
Merged
Conversation
…ust-lang/rust's place rust-lang/rust (998 MB, under the 1.5 GB cap) runs out of memory at replay time, so it never had a city and its featured slot stayed empty: the row showed nine cities. golang/go, the other language repo of its kind, replays in 40 s (3,748 commits fetched, 99.9 MB of packs).
…ommits" When every repo of a city failed to replay, finish found nothing to draw and answered "no commits in the last year". For rust-lang/rust that is 34,368 commits. The discovery-time check from fa997db only covers repos over the size cap; a repo under it can still fail at replay time (memory, time, fetch). finish now answers 422 repo_failed, naming the failed repos with their commit counts, whenever a repo with commits has no record; "no commits" remains for a city that really has none. The page fills in each failed repo's reason from its row in the build list, says how many commits it has (and, for too big or too long, that one hosted build cannot replay them), and offers Try again.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two accuracy fixes found while rebuilding the gallery on the new engine.
1. The featured row showed nine cities. rust-lang/rust is 998 MB on disk, under the 1.5 GB cap, but it runs out of the builder's memory at replay time (production, today: "too big for the hosted builder" after 35.9 s). So its city never existed, and the featured route skipped its slot.
golang/go, the other language repo of its kind, takes the slot. A production build replayed it in 40 s: 3,748 commits fetched, 99.9 MB of packs. The city's 3,491 commits are exactly GitHub's non-merge commits authored inside the window; how that number relates to GitHub's 3,748 is the next PR.
2. A city whose replays all failed said "no commits in the last year". For rust-lang/rust that is 34,368 commits. fa997db covered repos over the size cap at discovery; a repo under the cap can still fail at replay time (memory, time, fetch).
finishBuildnow answers422 repo_failedwhenever a repo with commits has no record. The answer names the failed repos with their commit counts. "No commits" remains only for a city that really has none.The page fills in each repo's reason from its row in the build list. It says how many commits the repo has, adds that one hosted build cannot replay them only when the reason is too big or too long, and offers Try again. Rendered headlessly against the real page, with only
fetchmocked to production's answers:Tests. A new finish-step test covers both answers:
repo_failedwith the name and 34,368 commits, andemptyfor a city with nothing to draw. It fails without the fix. Suite green; typecheck clean.Independent of #10; no file overlap.