Repository navigation
explore: the cities you built come first, marked "yours" - #17
Merged
Merged
Conversation
A city built from a browser was listed in the gallery but sat below the featured cities: under two rows on the home page and the ten-city Featured shelf on /explore, so whoever built it couldn't find it. city.js now keeps the last 24 cities this browser built in localStorage. site.js puts them, and your own city when signed in, first in the gallery list with a "yours" badge. /explore gets a Yours shelf above Featured. A city that has fallen out of the gallery's 60 latest builds still shows, from the browser's copy. Visitors who haven't built anything see the same page as before. The privacy section says the list stays in the browser. Also moves #15's section swap into web/site/index.html, the source that web/scripts/site.mjs stamps the page from. #15 edited only the generated page, so CI's "committed builds are up to date" check has failed since.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
azank1
marked this pull request as ready for review
October 19, 2026 16:48
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Someone who built a city couldn't find it afterwards. It was in the gallery, but under the featured cities: past the two rows the home page shows, and after the ten-city Featured shelf on /explore.
What changes
s/city.jskeeps the last 24 cities this browser built inlocalStorage(cc.mine), each as a gallery entry, when a build finishes.s/site.jsputs those cities, plus your own city when you're signed in, first in the gallery list, markedmine. Tiles markedmineget a "yours · person/org/repo" badge. If the gallery has a newer copy of a city, that copy is used. A city that has fallen out of the gallery's 60 latest builds still shows, from the browser's copy.Also fixes #15's edit.
web/public/*.htmlis generated byweb/scripts/site.mjsfromweb/site/. #15 edited only the generatedindex.html, so CI'sviewerjob (committed builds are up to date) has failed since5d37aae. The section swap is now inweb/site/index.html. Runningnode viewer/build.mjsand thennode web/scripts/site.mjsleaves the tree clean. The regenerated pages also pick up new?v=hashes forsite.cssandsite.js.Evidence
node --checkpasses on both scripts.remember()was run in Node three times (repeat key, missingwho, zero commits). The result was newest first with no duplicates, and shares of 0 instead of NaN.