Skip to content

https://github.com/azerothcore/azerothcore-wotlk/pull/26404#23

Open
Kitzunu wants to merge 1 commit into
masterfrom
26404
Open

https://github.com/azerothcore/azerothcore-wotlk/pull/26404#23
Kitzunu wants to merge 1 commit into
masterfrom
26404

Conversation

@Kitzunu

@Kitzunu Kitzunu commented Jul 14, 2026

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Bug Fixes
    • Updated creature spawn data to use separate minimum and maximum spawn-time values.
    • Preserved existing creature locations, attributes, and health and mana settings.

@coderabbitai

coderabbitai Bot commented Jul 14, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 263c11d0-4550-4c3a-b7da-fef871716b31

📥 Commits

Reviewing files that changed from the base of the PR and between adb3ffa and d290e36.

📒 Files selected for processing (1)
  • data/sql/db-world/guildhouses.sql

📝 Walkthrough

Walkthrough

The guildhouse creature insert for entry 55005 now uses separate minimum and maximum spawn-time columns, assigning 300 to both for every inserted row while preserving the existing entities and values.

Changes

Guildhouse spawn data

Layer / File(s) Summary
Creature insert schema update
data/sql/db-world/guildhouses.sql
The creature insert replaces spawntimesecs with SpawnTimeSecMin and SpawnTimeSecMax, setting both to 300 while retaining the existing creature rows and attributes.

Estimated code review effort: 2 (Simple) | ~10 minutes

Suggested reviewers: sudlud

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title is just a GitHub URL and does not describe the change in this pull request. Replace it with a concise summary of the actual change, such as updating guildhouse creature inserts for the new spawn-time schema.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch 26404

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant