feat(main): update proto GIT_TAG to service/v0.14.0#141
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates the protobuf definitions and regenerated Python client code to align with OpenTDF platform v0.14.0. Key changes include adding namespace scoping (namespace_id and namespace_fqn) to actions, registered resources, and subject mappings, introducing sorting capabilities (sort and SortDirection) across various list APIs, deprecating ListAttributeValues, adding a new GetObligationTrigger RPC, and removing certificate-related messages and RPCs from namespaces. Additionally, the code generation script was updated to preserve hand-crafted init.py files. As there are no review comments provided, I have no feedback to evaluate.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
a2c9c07 to
34ad1f4
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the OpenTDF platform protobuf files to version 0.14.0 and regenerates the Python protobuf and Connect RPC client files. Key changes include adding optional namespace scoping and sorting capabilities to various policy requests, deprecating legacy RPCs, and removing certificate-related definitions from namespaces. Feedback on these changes highlights a critical validation issue: several newly introduced optional namespace_id and namespace_fqn fields have strict validation constraints but lack the ignore = IGNORE_IF_ZERO_VALUE option, which will cause requests omitting these fields to fail validation on their default empty string values.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request updates the OpenTDF Python protobuf definitions to align with version v0.14.0 of the platform. Key changes include adding optional namespace scoping (via namespace ID and FQN) to actions, registered resources, subject mappings, and subject condition sets, introducing sorting capabilities across list APIs, and deprecating or removing certificate-related RPCs and messages from namespaces. Additionally, a new GetObligationTrigger RPC has been added. As there are no review comments, I have no feedback to provide on the review itself.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Uh oh!
There was an error while loading. Please reload this page.