Skip to content

feat(main): update proto GIT_TAG to service/v0.14.0#141

Merged
b-long merged 8 commits into
mainfrom
feat/service-0.14.0
Jun 10, 2026
Merged

feat(main): update proto GIT_TAG to service/v0.14.0#141
b-long merged 8 commits into
mainfrom
feat/service-0.14.0

Conversation

@b-long

@b-long b-long commented Jun 3, 2026

Copy link
Copy Markdown
Owner
  • feat(main): update proto GIT_TAG to service/v0.14.0
  • update some tests / separate from specific GIT_TAG used
  • update .gitattributes file, to influence Github & LLM code review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the protobuf definitions and regenerated Python client code to align with OpenTDF platform v0.14.0. Key changes include adding namespace scoping (namespace_id and namespace_fqn) to actions, registered resources, and subject mappings, introducing sorting capabilities (sort and SortDirection) across various list APIs, deprecating ListAttributeValues, adding a new GetObligationTrigger RPC, and removing certificate-related messages and RPCs from namespaces. Additionally, the code generation script was updated to preserve hand-crafted init.py files. As there are no review comments provided, I have no feedback to evaluate.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@b-long b-long force-pushed the feat/service-0.14.0 branch from a2c9c07 to 34ad1f4 Compare June 7, 2026 23:34
@b-long

b-long commented Jun 7, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenTDF platform protobuf files to version 0.14.0 and regenerates the Python protobuf and Connect RPC client files. Key changes include adding optional namespace scoping and sorting capabilities to various policy requests, deprecating legacy RPCs, and removing certificate-related definitions from namespaces. Feedback on these changes highlights a critical validation issue: several newly introduced optional namespace_id and namespace_fqn fields have strict validation constraints but lack the ignore = IGNORE_IF_ZERO_VALUE option, which will cause requests omitting these fields to fail validation on their default empty string values.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/otdf-python-proto/proto-files/policy/actions/actions.proto
Comment thread packages/otdf-python-proto/proto-files/policy/actions/actions.proto
@b-long

b-long commented Jun 10, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the OpenTDF Python protobuf definitions to align with version v0.14.0 of the platform. Key changes include adding optional namespace scoping (via namespace ID and FQN) to actions, registered resources, subject mappings, and subject condition sets, introducing sorting capabilities across list APIs, and deprecating or removing certificate-related RPCs and messages from namespaces. Additionally, a new GetObligationTrigger RPC has been added. As there are no review comments, I have no feedback to provide on the review itself.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@b-long b-long marked this pull request as ready for review June 10, 2026 01:49
@b-long b-long merged commit 7d5a5b6 into main Jun 10, 2026
11 checks passed
@b-long b-long deleted the feat/service-0.14.0 branch June 10, 2026 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant