feat(main): update dependencies & switch to uv workspace layout#142
Conversation
There was a problem hiding this comment.
Code Review
This pull request restructures the repository into a monorepo workspace using uv, moving the SDK and proto packages into a packages/ directory and updating workspace configurations, Release Please settings, and test paths. The review feedback suggests keeping the root uv.lock file updated with otdf-python-proto version bumps in the Release Please configurations, moving code generation tools from runtime dependencies to development dependencies in packages/otdf-python/pyproject.toml, using the standard python_version marker for tomli, and utilizing the project_root fixture directly in tests/test_cli.py for cleaner path resolution.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
- move codegen tools to dev deps - add uv.lock proto version entry to release-please configs - use project_root fixture in test_cli_version
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request restructures the repository into a monorepo layout, moving the SDK and protobuf code into separate subdirectories under packages/. However, a critical security vulnerability was introduced by replacing the official httpx library with httpx2, which is a known typosquatted package. Feedback strongly advises reverting all dependencies, imports, and test mocks back to the official httpx library, restoring respx for HTTP mocking, and deleting the obsolete compatibility test file.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This pull request updates to httpx2 from httpx (see Pydantic's announcement at https://github.com/pydantic/httpx2), it also updates to connect-python>=0.9.0 .
In addition, we reorganize the repository structure to move the Python packages under a unified
packages/directory and updates configuration, workflows, and documentation accordingly. The changes aim to improve maintainability and clarity for multi-package management, streamline CI workflows, and ensure release tooling targets the correct locations.