Skip to content

feat(main): update dependencies & switch to uv workspace layout#142

Merged
b-long merged 8 commits into
mainfrom
workspace-restructure
Jun 4, 2026
Merged

feat(main): update dependencies & switch to uv workspace layout#142
b-long merged 8 commits into
mainfrom
workspace-restructure

Conversation

@b-long

@b-long b-long commented Jun 4, 2026

Copy link
Copy Markdown
Owner

This pull request updates to httpx2 from httpx (see Pydantic's announcement at https://github.com/pydantic/httpx2), it also updates to connect-python>=0.9.0 .

In addition, we reorganize the repository structure to move the Python packages under a unified packages/ directory and updates configuration, workflows, and documentation accordingly. The changes aim to improve maintainability and clarity for multi-package management, streamline CI workflows, and ensure release tooling targets the correct locations.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the repository into a monorepo workspace using uv, moving the SDK and proto packages into a packages/ directory and updating workspace configurations, Release Please settings, and test paths. The review feedback suggests keeping the root uv.lock file updated with otdf-python-proto version bumps in the Release Please configurations, moving code generation tools from runtime dependencies to development dependencies in packages/otdf-python/pyproject.toml, using the standard python_version marker for tomli, and utilizing the project_root fixture directly in tests/test_cli.py for cleaner path resolution.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread .release-please-config-develop.json
Comment thread .release-please-config.json
Comment thread packages/otdf-python/pyproject.toml
Comment thread packages/otdf-python/pyproject.toml
Comment thread tests/test_cli.py Outdated
b-long added 2 commits June 3, 2026 20:19
- move codegen tools to dev deps
- add uv.lock proto version entry to release-please configs
- use project_root fixture in test_cli_version
@b-long b-long changed the title chore(main): switch to uv workspace with packages layout feat(main): switch to uv workspace with packages layout Jun 4, 2026
@b-long

b-long commented Jun 4, 2026

Copy link
Copy Markdown
Owner Author

/gemini review

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request restructures the repository into a monorepo layout, moving the SDK and protobuf code into separate subdirectories under packages/. However, a critical security vulnerability was introduced by replacing the official httpx library with httpx2, which is a known typosquatted package. Feedback strongly advises reverting all dependencies, imports, and test mocks back to the official httpx library, restoring respx for HTTP mocking, and deleting the obsolete compatibility test file.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread packages/otdf-python/pyproject.toml
Comment thread packages/otdf-python/src/otdf_python/sdk_builder.py
Comment thread packages/otdf-python/src/otdf_python/token_source.py
Comment thread tests/test_sdk_builder.py
Comment thread tests/test_token_source.py
Comment thread tests/test_token_source.py
Comment thread tests/test_kas_connect_rpc_httpx_compat.py Outdated
@b-long b-long changed the title feat(main): switch to uv workspace with packages layout feat(main): httpx2 and switch to uv workspace layout Jun 4, 2026
@b-long b-long marked this pull request as ready for review June 4, 2026 01:16
@b-long b-long changed the title feat(main): httpx2 and switch to uv workspace layout feat(main): update dependencies & switch to uv workspace layout Jun 4, 2026
@b-long b-long merged commit 649f63c into main Jun 4, 2026
11 checks passed
@b-long b-long deleted the workspace-restructure branch June 4, 2026 21:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant