Skip to content

fix: increase testing, fix misconfiguration#148

Merged
b-long merged 1 commit into
mainfrom
fix/stale-todo-and-test-assertions
Jun 4, 2026
Merged

fix: increase testing, fix misconfiguration#148
b-long merged 1 commit into
mainfrom
fix/stale-todo-and-test-assertions

Conversation

@b-long

@b-long b-long commented Jun 4, 2026

Copy link
Copy Markdown
Owner

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the SDK exception tests in tests/test_sdk.py to use pytest.raises instead of try/except blocks, and adds new test cases for exception attributes and messages. It also removes a TODO comment from policy_stub.py. The review feedback suggests adding an assertion to verify that the context manager exit actually calls close() on the services object, as the test currently lacks this verification.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread tests/test_sdk.py
@b-long b-long force-pushed the fix/stale-todo-and-test-assertions branch from 3bc18a7 to dd253d0 Compare June 4, 2026 21:14
@b-long b-long changed the title fix(main): remove stale TODO and expand exception test assertions fix: increase testing, fix misconfiguration Jun 4, 2026
@b-long b-long merged commit 1dc8c45 into main Jun 4, 2026
11 checks passed
@b-long b-long deleted the fix/stale-todo-and-test-assertions branch June 4, 2026 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant