fix: crisp text at every UI scale and restore scrolling in every view - #19
Merged
Merged
Conversation
Apply the Text & UI scale preference with CSS zoom instead of a transform. The transform stretched the rendered raster, which blurred glyphs at any non-integer scale, and forced the whole shell into a composited layer that lost subpixel text antialiasing even at 100%. zoom re-lays out the subtree at the chosen size. The shared workspace panel rule set overflow: hidden with higher specificity than each view's own overflow: auto, so History, Stats, Reviews, Dependencies, Themes, and Settings could not be scrolled. Panels now scroll by default and only the views with internal scroll regions clip.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two regressions reported after 0.1.18.
Blurry UI. The Text & UI scale preference was applied with
transform: scale()on the shell (since 0.1.16). A transform stretches the already-rendered raster, so every non-integer scale blurs glyphs, and it forces the whole app into a composited layer, which on macOS drops subpixel text antialiasing even at 100%. The scale is now applied with CSSzoom, which re-lays out the subtree at the chosen size. WebKit (WKWebView and WebKitGTK) has supportedzoomfor years. Verified with 4× magnified captures at 100% and 120%: the transform build shows soft glyph edges at 120%, the zoom build is crisp at both.Scrolling. The shared
.workspace > sectionpanel rule setoverflow: hiddenwith higher specificity than each view'soverflow: auto, so History, Stats, Reviews, Dependencies, Themes, and Settings could not be wheel-scrolled. Panels now default tooverflow: auto; only Code, Security, Analysis, and Logs (which scroll internally) clip. Verified per view by computed overflow and scroll movement in Chrome.Verification