fix: upgrade x/crypto for CVE-2026-56854 and goldmark for GO-2026-5320 - #20
Merged
Merged
Conversation
golang.org/x/crypto v0.53.0 -> v0.55.0 closes CVE-2026-56854 (GO-2026-6303), a source-address enforcement gap in the SSH server's authentication callbacks. Abduction never calls ssh.NewServerConn; the module arrives through Wails' dev server dependency, so this clears the advisory rather than a reachable path. github.com/yuin/goldmark v1.7.4 -> v1.7.17 closes GO-2026-5320, an XSS in link, image, and autolink rendering that govulncheck reports as reachable from the Markdown reader. Output was already sanitised before display.
b404dev
force-pushed
the
fix/cve-2026-56854
branch
from
September 4, 2026 14:18
091da72 to
8430808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CVE-2026-56854 / GO-2026-6303 in
golang.org/x/crypto/ssh:source-addressrestrictions returned by password, keyboard-interactive, no-client-auth, and GSSAPI callbacks were not enforced. Fixed upstream in v0.55.0. Abduction pullsx/cryptov0.53.0 transitively through Wails' dev server (labstack/echo→x/crypto/acme) and never callsssh.NewServerConn;govulncheckconfirms no reachable path. Bumped to v0.55.0 so scanners stop flagging the module.x/net,x/sys, andx/textmoved to their matching minors.GO-2026-5320 in
github.com/yuin/goldmark: while scanning,govulncheckreported this XSS in link, image, and autolink rendering as reachable frombackend/code.go(renderMarkdown). Rendered HTML is already sanitised before display, so exposure was mitigated, but the dependency is now on v1.7.17 where it is fixed.Verification
go build ./...,go vet ./...pass.govulncheck ./...reports no vulnerabilities after the bump.