Skip to content

chore: bump helm support to 4.x #642

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
disrupted merged 1 commit into from
Jan 29, 2026
Merged

chore: bump helm support to 4.x #642

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions kpops/component_handlers/helm_wrapper/helm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,8 +55,8 @@ def __init__(self, helm_config: HelmConfig) -> None:
self._context = helm_config.context
self._debug = helm_config.debug

if self.version.major != 3:
msg = f"The supported Helm version is 3.x.x. The current Helm version is {self.version.major}.{self.version.minor}.{self.version.patch}"
if self.version.major < 3 or self.version.major > 4:
msg = f"The supported Helm version is 3.x.x|4.x.x. The current Helm version is {self.version.major}.{self.version.minor}.{self.version.patch}"
raise RuntimeError(msg)

@cached(cache={}, key=cache_key)
Expand Down
6 changes: 5 additions & 1 deletion tests/component_handlers/helm_wrapper/test_helm_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -594,6 +594,10 @@ def test_should_call_run_command_method_when_helm_template_without_optional_args
("v3.12.0", Version(3, 12, 0)),
("v3.12", Version(3, 12, 0)),
("v3", Version(3, 0, 0)),
("v4.1.0+4553a0a", Version(4, 1, 0)),
("v4.1.0", Version(4, 1, 0)),
("v4.1", Version(4, 1, 0)),
("v4", Version(4, 0, 0)),
],
)
def test_parse_version(
Expand All @@ -620,7 +624,7 @@ def test_should_raise_exception_if_helm_version_is_old(
mock_execute.return_value = "v2.9.0+gc9f554d"
with pytest.raises(
RuntimeError,
match="The supported Helm version is 3.x.x. The current Helm version is 2.9.0",
match="The supported Helm version is 3.x.x|4.x.x. The current Helm version is 2.9.0",
):
Helm(helm_config=HelmConfig())

Expand Down
Loading