Repository navigation
chore: codebase audit 2, design system - #31
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Codebase audit, part 2:
design/and everything that consumes it. The design system is now a complete brandbook, simpler, free of internal contradictions, and enforced in CI. The app, the landing page, the docs site, the repo docs and every screenshot follow it.brand.mdis a brandbook (positioning and boilerplate, logo and mascot rules, color and type at a glance, imagery, naming, attribution, App Store badge rules from Apple's guidelines).components.mdsplits drawn components from system controls, which it only names. One capitalization rule everywhere (controls Title Case, content sentence case), Send as link terminology with a "link server" term, MiB/GiB only for exact binary thresholds, and an approved list of six security claims. Web-only tokens all carry awebsegment; dead tokens are removed.scripts/verify-design.shcheckstokens.css=DesignTokens.swift= color sets, fails on a shared token with no mirror decision, and lints app Swift and web CSS/HTML for literals and springs.verify-contrast.shcovers more pairs and rules (and no longer truncates multi-line tokens). Thecontrastjob (now named "design checks") runs both on design, app Swift, color set and web CSS/HTML changes.AGENTS.mdpoints atdesign/and requiresapple-design,swiftui-expert-skill,mobile-ios-designandapple-appstore-reviewerfor the matching work, with install commands.scripts/capture-screenshots.sh, web copies refreshed.AI assistance: substantial
Verification
xcodebuildmacOS and iOS Simulator builds: succeeded.CrocAppTests(macOS): 266 passed.scripts/format-swift.sh --lint: pass.scripts/verify-design.shandscripts/verify-contrast.sh: exit 0.web/docs:pnpm buildandpnpm typecheckpass.scripts/capture-screenshots.sh: all outputs present and sized; accept gate, waiting, sending and Home checked by eye in light and dark.verify-design.shhas not run under mawk before this PR's CI.Docs
## [Unreleased]inCHANGELOG.mddesign/,docs/knowledge/,AGENTS.mdUI changes
Screenshots in
assets/screenshots/are recaptured in this PR (light and dark, every device).scripts/verify-contrast.shandscripts/verify-design.shpass