Repository navigation
chore: resolve the OpenSSF Scorecard alerts - #32
Merged
Merged
Conversation
Fuzzing: add Go native fuzz targets for relayPorts, validateThrottle, proxyURL, classify and splitPaths. Fix the relayPorts range check, which overflowed for huge BasePort or Transfers values and let them through (or panicked in make); both extremes are now fuzz seeds. Vulnerabilities: ignore GO-2026-5932 (x/crypto/openpgp, never imported) and GHSA-vfj7-8cjw-p6xm (braces, build-time only), neither of which has a fixed release, in osv-scanner.toml next to each manifest. Record the four dismissed alerts in docs/known-issues.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
Resolves the six open OpenSSF Scorecard code-scanning alerts.
relayPorts,validateThrottle,proxyURL,classifyandsplitPaths, seeded from the existing table tests. Writing them found an overflow inrelayPorts:base+n > 65535wrapped for huge values, soBasePort: math.MaxIntwas accepted (ports past 65535) andTransfers: math.MaxIntpanicked inmake. The check is nowbase > 65535-n, and both extremes are seeds. Not reachable from the app, whose Advanced settings validate ports first (AdvancedSettingsValidation.portsError).crocmobile/osv-scanner.tomlignores GO-2026-5932 (x/crypto/openpgp, never imported; govulncheck: not called) andweb/docs/osv-scanner.tomlignores GHSA-vfj7-8cjw-p6xm (braces, docs build only, already accepted). Scorecard's Vulnerabilities check reads that file next to each manifest.docs/known-issues.md.AI assistance: substantial
Verification
go vet ./...clean;env -u GOOS -u GOARCH go test -race ./...incrocmobile/:ok.go test -run=^$ -fuzz=^<Name>$: no failures (0.3-1.3 M execs each).FuzzRelayPortsseeds fail against the old check (seed#7,seed#8) and pass with the fix.osv-scanner scan source -r --no-call-analysis=go .(2.7.0): both IDs filtered, "No issues found".scripts/verify-*.shharness: not run,session.gounchanged.Docs
docs/known-issues.mdline deleted or added