Conversation
Adds 65 new unit tests targeting the lowest-coverage files in the codecov report for PR #294: - DynamicPredicateBuilderEdgeCaseTests (29 cases): IsValidPropertyName null/empty/oversized/dangerous-char branches, ValidateExpression null/whitespace + all dangerous patterns, ValidateArrayValue null/string/non-enumerable/empty branches. - DynamicPredicateExpressionOverloadTests (12 cases): Expression<Func<T,bool>> DynamicAnd/DynamicOr property-name and raw-expression overloads, plus the ExpressionStarter raw-expression overloads (none of these were exercised by existing tests). - LocalBlobServiceEdgeCaseTests (7 cases): Null RootFolder fallback, path-traversal UnauthorizedAccessException on CheckExists/Delete, leading-slash normalization, cancellation- token early-exit for file and folder deletion, nested-path SaveAsync. - DataSeedingEdgeCaseTests (3 cases): Empty seed data early-return, all-rows-already-exist early-return (using a value-equality ColorRow + ColorDbContext), and the default Order/EntityType/SeedAsync properties. All new tests pass; existing tests still green. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
test: improve coverage for PR #294 gap files
…ansitives Bump all outdated packages to their latest stable versions and resolve two High-severity transitive vulnerabilities surfaced by NuGetAudit. Security: - MessagePack 2.5.192 (GHSA-hv8m-jj95-wg3x) — cleared by Aspire.Hosting 13.4.6 pulling a fixed StreamJsonRpc/MessagePack. - SQLitePCLRaw.lib.e_sqlite3 2.1.11 (GHSA-2m69-gcr7-jv3q) — overridden to the fixed 3.0.x line via a direct SQLitePCLRaw.bundle_e_sqlite3 3.0.3 reference in the seven EF Core Sqlite-backed test projects. Notable bumps: - EF Core + Microsoft.Extensions.* 10.0.8 -> 10.0.9 - Aspire.Hosting(.SqlServer) 13.2.4 -> 13.4.6 (requires OpenTelemetry 1.16.0 and System.IdentityModel.Tokens.Jwt 8.19.1, both bumped — also clears the OpenTelemetry 1.13.1 NU1902 moderate advisories) - AWSSDK, Azure.Storage.Blobs, Mapster, Testcontainers, Microsoft.NET.Test.Sdk, coverlet, Meziantou.Analyzer, Microsoft.CodeAnalysis.NetAnalyzers, Markdig, PuppeteerSharp 24->25, YamlDotNet 17->18 Verified: clean restore (0 audit findings), full solution build succeeds with zero warnings/errors. Pre-existing test failures on dev (AspCore.Tasks reflection bug, flaky Hook/AuditLog isolation, Idempotency connection-string assertion) are unchanged by this update. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
1. fix(data-authorization): DataOwnerHook stamped CreatedOn with DateTimeOffset.Now (local time). Use UtcNow to match AuditedEntity and keep audit timestamps timezone-independent. 2. fix(extensions): NextSeqValueWithFormat used DateTime.Now for the date token in generated sequence codes. Use UtcNow so codes are deterministic regardless of server time zone. 3. perf(blob-aws): DeleteFolderAsync deleted objects one round-trip at a time. Batch each ListObjectsV2 page (<=1000 keys) into a single DeleteObjectsAsync call. 4. perf(blob): ValidateFile called BinaryData.ToArray() — copying the entire payload — just to read its length. Use ToMemory().Length (no copy). 5. fix(extensions): AsyncEnumerableExtensions.ToListAsync now guards its public argument with ArgumentNullException.ThrowIfNull instead of throwing an opaque NRE. Verified: dotnet build -c Debug => 0 warnings, 0 errors; Fw.Extensions (149), EfCore.DataAuthorization (20), EfCore.Extensions (85), Svc.BlobStorage (102) tests all pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
📊 Code Coverage Report |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #303 +/- ##
==========================================
- Coverage 84.83% 84.15% -0.68%
==========================================
Files 159 159
Lines 3706 3712 +6
Branches 575 574 -1
==========================================
- Hits 3144 3124 -20
Misses 412 412
- Partials 150 176 +26
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces configuration and documentation updates to support "Understand-Anything" knowledge graph tooling, removes GitNexus agent skill files and guidance, and adds an LLM-maintained wiki for the DKNet Framework. The changes focus on integrating new AI-powered code understanding features and streamlining existing agent-related documentation.
Integration of Understand-Anything tooling:
.understand-anything/directory with configuration (config.json), ignore patterns (.understandignore), meta information (meta.json), and large files tracked via Git LFS (knowledge-graph.json,fingerprints.json). This enables automated knowledge graph analysis and context-aware code understanding. [1] [2] [3] [4] [5] [6] [7].claude/settings.jsonto enable related plugins and marketplaces for enhanced AI capabilities.Removal and cleanup of GitNexus agent guidance:
.claude/skills/gitnexus/and removed the detailed agent workflow and conventions fromAGENTS.md. [1] [2] [3] [4] [5] [6] [7]CLAUDE.mdto remove references to the deleted agent files and simplify the guidance for AI code assistants. [1] [2] [3] [4]Addition of DKNet wiki for LLM-based documentation:
docs/wiki/directory with a newCLAUDE.mddescribing the wiki's conventions,meta.jsonfor analysis metadata, and content articles such asaggregate-root.mdto serve as an LLM-readable, maintainable knowledge base for the DKNet Framework. [1] [2] [3]Other adjustments:
.vscode/extensions.jsonto remove themarkdown-preview-enhancedextension from recommendations.These changes collectively shift the repository's AI guidance and documentation strategy from GitNexus agent workflows to a more general, maintainable, and LLM-friendly approach.