refactor: weekly code-quality pass — 5 fixes (2026-06-29)

[baoduy]

Weekly code-quality pass (2026-06-29)

Five targeted improvements found by reviewing the library source. Each is low-risk and behaviour-preserving on the success path. Categories: correctness/robustness, cancellation propagation, perf, and magic-number cleanup.

1. Harden fire-and-forget audit publishing — EfCoreAuditHook

The background Task.Run that runs audit publishers only caught DbUpdateException. Any other publisher failure escaped as an unobserved task exception, which can surface on the finalizer thread and tear down the process. Now catches Exception and logs it, explicitly discards the fire-and-forget task (_ =), and renames the void PublishLogsAsync → PublishLogs (it returns no awaitable).

2. Propagate CancellationToken through paging APIs

SpecRepoExtensions.ToPagedListAsync (both overloads), ModelSpecRepoExtensions.ToPagedListAsync, and RepoExtensions.SpecsToPageListAsync took no token, so a paged query could not be cancelled mid-flight. Added an optional CancellationToken and flowed it into X.PagedList.EF.ToPagedListAsync.

3. Name the default page size — PageAsyncEnumeratorExtensions

ToPageEnumerable(..., int pageSize = 100) → DefaultPageSize constant.

4. Name the default SAS lifetime — AzureStorageBlobService

Hardcoded TimeSpan.FromDays(1) for the default SAS expiry → DefaultSasLifetime field, with a clearer comment.

5. Drop gratuitous Task.Run — TokenResolver.ResolveAsync

Resolve is synchronous, CPU-bound reflection. Wrapping it in Task.Run inside a library wastes a thread-pool thread and adds a context switch for no benefit. Returns Task.FromResult(...) and lets the caller decide whether to offload. (ITokenExtractor.ExtractAsync was intentionally left as-is — it is fanned out via Task.WhenAll, where the offload provides real parallelism.)

Verification

• dotnet build DKNet.FW.sln -c Debug → 0 warnings, 0 errors (TreatWarningsAsErrors=true).
• Tests passing: Transform (44/44), Fw.Extensions (149/149), Repos paging (2/2), Specifications paging (31/31).
• MsSql TestContainers integration tests are skipped/failing only because the SQL Server amd64 image segfaults under QEMU on the ARM host (environment limitation). One AuditLogs fire-and-forget timing test is flaky under parallel execution on dev too (verified by reverting the hook) — unrelated to this change.

🤖 Generated with Claude Code

[github-actions]

📊 Code Coverage Report

| Metric | Coverage |
|--------|----------|
| **Line Coverage** | 87.8% |
| **Branch Coverage** | 80.6% |
| **Method Coverage** | 86% |

**Lines:** 3267/undefined covered
**Branches:** 1211/undefined covered

📈 [View Full Coverage Report](https://github.com/baoduy/DKNet/actions/runs/28331730333)

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 84.26%. Comparing base (b06bb04) to head (c06d416).

Additional details and impacted files

@@            Coverage Diff             @@
##              dev     #312      +/-   ##
==========================================
+ Coverage   84.15%   84.26%   +0.10%     
==========================================
  Files         159      159              
  Lines        3712     3718       +6     
  Branches      574      574              
==========================================
+ Hits         3124     3133       +9     
+ Misses        412      409       -3     
  Partials      176      176              

Flag	Coverage Δ
unittests	84.26% <100.00%> (+0.10%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.