fix: strip zoom auto-visibility display from migrated label group styles - #66
Merged
Merged
Conversation
Pre-1.140 zoom auto-visibility hid burg label tiers with an inline display: none, and a map saved while zoomed out carried it in the group's style attribute. The 1.140 migration harvested it verbatim into the persisted label group style, the 1.150 store migration kept it, and since the store is applied over the saved svg on load, those tiers never rendered again at any zoom. Strip display in labelStyleFromLegacy, the funnel for both harvests, and add a 1.151.2 pass over the stored label group styles for maps saved by 1.150-1.151.1, which already carry the value in their styles record. Closes Azgaar#1773
✅ Deploy Preview for bazgaars-fmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This was referenced Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fork port of Azgaar#1802 (upstream issue Azgaar#1773). Cherry-pick of d98dcb8; the only fork-side difference is the package version
1.151.2-fork.1.Problem
Pre-1.140 zoom auto-visibility hid burg label tiers with an inline
display: none, and a map saved while zoomed out carries it in the group'sstyleattribute. The 1.140 migration harvested it verbatim into the persisted label group style, the 1.150 store migration kept it, and since the store is applied over the saved svg on load, those tiers never render again at any zoom.Fix
stripDisplay()instyles-legacy.ts, applied inlabelStyleFromLegacy, the single funnel for both the 1.140 svg harvest and the 1.150 store migration.auto-update.tsgated onisOlderThan("1.151.2")that stripsdisplayfrom every stored label group style, for maps saved by 1.150-1.151.1.Verification
tsc --noEmitand Biome clean.displayin the DOM or the store, no page errors. The unfixed baseline hides hamlet, village, trading post, monastery and fort on both files.