Skip to content

Reset language settings before each full e2e test #474

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bartekplus merged 3 commits into from
Oct 5, 2026
Merged

Reset language settings before each full e2e test #474

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5984cb2
fix(e2e): enable all languages in the measurement unit test
bartekplus Oct 5, 2026
a3e98b3
fix(e2e): reset the language settings before each full-suite test
bartekplus Oct 5, 2026
503631d
fix(e2e): reset the full-suite baseline after all setting writes
bartekplus Oct 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 19 additions & 0 deletions tests/e2e/e2e-helpers.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,25 @@ export async function setSettings(
);
}

/**
* True when a stored setting is not equal to its value in `settings`. It also
* finds writes from extension pages and commands, which `setSettings` does not see.
*/
export async function storedSettingsDiffer(
worker: BackgroundContext,
settings: Record<string, unknown>,
): Promise<boolean> {
const stored = await withWorker(worker, (context) =>
context.evaluate(
(keys) => chrome.storage.local.get(keys),
Object.keys(settings).map((key) => `${SETTINGS_PREFIX}${key}`),
),
);
return Object.entries(settings).some(
([key, value]) => stored[`${SETTINGS_PREFIX}${key}`] !== JSON.stringify(value),
);
}

export async function setSetting(
worker: BackgroundContext,
key: string,
Expand Down
Loading
Loading