Google Docs: do not show suggestions when a click only moves the caret

[bartekplus]

Problem

In Google Docs, a click into existing text opened the suggestion menu, and an arrow key did the same, without any typing.

Root cause

The Docs adapter reads the model every 200 ms. It asks for suggestions when the new snapshot differs from the last one. A click (pointerdown) and each key call dismiss(), and dismiss() sets the stored snapshot to null. The next poll then has no snapshot to compare against, so it reads the moved caret as a change and asks for suggestions.

Fix

GoogleDocsAdapter has a new edited flag:

• These actions set it: a keystroke, an input or a paste (queueEdit), the end of an IME composition, and our own write. Thus the next-word menu still shows after an accepted word.
• dismiss() clears it.
• A read uses the flag one time. A read without an edit or an explicit request (force, for example Ctrl+Space) asks for no suggestions.

Other editors

I checked whether other editors have the same bug. A new e2e test runs the same steps in 24 editor setups, each in menu mode and inline mode:

• textarea, input and contenteditable
• React-controlled input and textarea
• CKEditor 4 and 5, Quill (classic, bundled 1, bundled 2)
• Lexical, ProseMirror, Slate, TinyMCE (inline, iframe)
• Gutenberg (inline, iframe canvas), Draft.js, Trix, Froala, Summernote, Tiptap, RoosterJS
• the Notion-like page

For each one, it types text, then clicks into the middle of a word, presses arrow keys, and clicks back into the field from outside. All 48 cases pass in Chrome, so the bug is only in Google Docs. To prove the test can catch the bug, I added a click-triggered prediction on purpose. Then the test failed for textarea, contenteditable, Lexical and Notion.

Tests

• Unit: tests/GoogleDocsAdapter.test.ts fails without the fix.
• Integration: tests/e2e/google-docs.e2e.test.ts has a new test for a click and an arrow key that only move the caret. Without the fix, the menu opens. With the fix, all 91 Docs e2e tests pass.
• E2E full: the editor matrix above.
• bun run check, bun run test (0 failures) and bun run check:e2e:coverage pass. The coverage matrix has a new behavior, caret_move_shows_no_suggestion.

Reviewer notes

• Firefox: I could not run the new e2e test in Firefox. Firefox does not start on my machine ("Could not find profile folder"). Please rely on CI for Firefox.
• Live Google Docs: I have not tested this in live Google Docs. The fixture is a copy of the Docs DOM and bridge, not the real product.

🤖 Generated with Claude Code

[chatgpt-codex-connector]

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.