Skip to content

feat(devnet): Unify Docker Devnet Binary#3686

Draft
refcell wants to merge 4 commits into
mainfrom
rf/feat/unify-docker-devnet-binary
Draft

feat(devnet): Unify Docker Devnet Binary#3686
refcell wants to merge 4 commits into
mainfrom
rf/feat/unify-docker-devnet-binary

Conversation

@refcell

@refcell refcell commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

This migrates the local Docker devnet L2 nodes onto the unified base binary. Sequencer nodes now run base sequencer, validator and RPC nodes run base rpc, and the L2 bootnode runs base bootnode. The old local Docker build targets and service wiring for separate base-reth-node, base-builder, and base-consensus images are removed, with docs and helper scripts updated to match.

Co-authored-by: Codex <codex-noreply@coinbase.com>
@refcell refcell added feature New feature infra Area: infra labels Jun 22, 2026
@refcell refcell self-assigned this Jun 22, 2026
@cb-heimdall

cb-heimdall commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

Comment thread crates/execution/cli/src/standard_node.rs Outdated
Co-authored-by: Codex <codex-noreply@coinbase.com>
Comment thread crates/execution/cli/src/standard_node.rs Outdated
Comment thread crates/infra/basectl/src/config.rs
refcell and others added 2 commits June 22, 2026 14:56
Co-authored-by: Codex <codex-noreply@coinbase.com>
Co-authored-by: Codex <codex-noreply@coinbase.com>
@github-actions

Copy link
Copy Markdown
Contributor

Review Summary

The PR cleanly unifies the Docker devnet onto the single base binary, removing the separate base-reth-node, base-builder, and base-consensus Docker build targets and service definitions. The Rust-side refactoring to extract MeteringArgs into its own struct is well-structured.

Previous review issues — all addressed:

  • The MeteringArgs sub-struct extraction resolves the earlier duplicate-clap-args bug that would have broken the standalone base-reth-node binary, and also eliminates the maintenance hazard of duplicated metering field definitions.
  • The new ConductorControl::restart_containers() method correctly deduplicates container names, preventing the double-restart problem when docker_el and docker_cl point to the same unified container.

No new issues found. The code changes are correct and well-tested.

@github-actions

Copy link
Copy Markdown
Contributor

✅ base-std fork tests: all 616 passed

base/base is fully in sync with the base-std spec.

Dependency Ref Commit
base-std main 4658f1b7
base-anvil 0092692587d8d064dd2c6923ce26a682c58f3694 00926925

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature New feature infra Area: infra

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants