Skip to content

Comments

fix(flashblocks): handle lagged errors in canonical state stream#836

Open
MidSage0614 wants to merge 1 commit intobase:mainfrom
MidSage0614:fix/canonical-state-stream-lagged
Open

fix(flashblocks): handle lagged errors in canonical state stream#836
MidSage0614 wants to merge 1 commit intobase:mainfrom
MidSage0614:fix/canonical-state-stream-lagged

Conversation

@MidSage0614
Copy link
Contributor

wait_for_canonical_receipt used while let Some(Ok(...)) which exits the loop on any error including RecvError::Lagged, causing the function to return None prematurely when the canonical state stream lags, changed to explicit match to log lagged errors and continue waiting.

@cb-heimdall
Copy link
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 1
Sum 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants