Skip to content

feat: improve base makefile usability#185

Merged
jackchuma merged 3 commits intomainfrom
jack/improve-makefile
Mar 2, 2026
Merged

feat: improve base makefile usability#185
jackchuma merged 3 commits intomainfrom
jack/improve-makefile

Conversation

@jackchuma
Copy link
Collaborator

@jackchuma jackchuma commented Mar 2, 2026

Summary

  • Refactor Makefile to use an explicit ENV parameter (testnet-alpha, testnet-prod, mainnet) instead of a hardcoded ENV_NAME variable, so switching environments no longer requires editing the Makefile
  • Add input validation (validate-env) with clear error messages when ENV is missing or invalid
  • Add a help target documenting all available targets, environments, and overridable variables
  • Read contract addresses (including LocalERC20) from per-environment deployment JSON files instead of hardcoding them
  • Fix check-root and check-count to use the dynamic BASE_RPC and BRIDGE address instead of hardcoded values
  • Remove the dev-deploy composite target

Test plan

  • make help prints usage info
  • make bridge-sol-to-solana ENV=testnet-alpha resolves correct RPC, deployment file, and contract addresses
  • Running any target without ENV prints a clear error
  • Running with an invalid ENV value prints a clear error
  • make check-root ENV=mainnet uses mainnet RPC and bridge address

@cb-heimdall
Copy link
Collaborator

cb-heimdall commented Mar 2, 2026

✅ Heimdall Review Status

Requirement Status More Info
Reviews 1/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@jackchuma jackchuma requested review from leopoldjoy and xenoliss March 2, 2026 18:22
@jackchuma jackchuma merged commit ad9bba5 into main Mar 2, 2026
7 checks passed
@jackchuma jackchuma deleted the jack/improve-makefile branch March 2, 2026 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants