Fix incorrect cd path in template-funding README#589
Open
meelon-dev wants to merge 1 commit intobase:mainfrom
Open
Fix incorrect cd path in template-funding README#589meelon-dev wants to merge 1 commit intobase:mainfrom
meelon-dev wants to merge 1 commit intobase:mainfrom
Conversation
Collaborator
🟡 Heimdall Review Status
|
jackchuma
approved these changes
Feb 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
README.mdfile for thetemplate-fundinguses the following line:This does not follow the logic, as it selects the execution bundle for the swap owner, not for funding:
mainnet/2025-06-25-safe-swap-owner/README.mdcorrectly refers to thesafe-swap-owner.mainnet/2025-08-13-safe-swap-owner/README.mdalso correctly refers to thesafe-swap-owner.mainnet/2025-10-06-funding/README.mdfollows the logic and hascd mainnet/2025-10-06-funding.A comparison shows that the
template-fundingsimply copies thesafe-swap-ownerpath, which is not adapted for funding.Updated template-funding so that the path follows the funding logic.