refactor(vibenet): size the Validity price chart to its container - #129
Open
BrianBland wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🟡 Heimdall Review Status
|
Replace the fixed 960x440 viewBox with a ResizeObserver-measured canvas so the chart draws in CSS pixels at any container shape. Prepares the chart to sit beside the order ticket without letterboxing; visually a no-op at today's full-width layout. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/validity-ui-1-chart-sizing
branch
from
September 3, 2026 00:20
c5b23f8 to
9b7792a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 1/9 of the Validity demo UI rework (stacked on #128).
Replaces the fixed 960×440 viewBox with a ResizeObserver-measured canvas so the chart draws in CSS pixels at any container shape. This prepares the chart to sit beside the order ticket (part 3) without letterboxing — at today's full-width layout this is visually a no-op.
toCandlesand friends are untouched; existingPriceCandles.test.tsstill passes.Generated with Claude Code
Full stack view below
