feat(vibenet): put the Validity chart and order ticket side by side - #131
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🟡 Heimdall Review Status
|
…tral AMM (BASE-422) The AMM pool and its maker flow now run on central vibenet infrastructure (the actor system), so the demo no longer runs actors in the browser. - Remove the client-side maker subaccounts, the startBots swap loop, and the client-side ensureSingleton pool deploy (+ the "Deploy shared pool" button). - Keep read-only probeSingleton discovery — deterministic CREATE2 means the browser rediscovers exactly what vibenet-setup deployed — plus the candle/ price display and the user's own inventory + conditional orders. - Show a "pool is coming online" state for the window before the actors are live. Delete the now-dead code the cutover leaves behind: - lib/bots.ts + lib/makers.ts (and their tests) — no longer referenced. - ensureSingleton() and its write-path helpers in lib/singleton.ts; keep the probeSingleton()/predictSingleton() read chain (still used + tested). - encodeSwapLegs() in lib/amm.ts (only the deleted bots.ts used it). - The now-unwritten accountId / makerAccountIds fields in the persisted store. Co-Authored-By: Claude <noreply@anthropic.com>
Replace the fixed 960x440 viewBox with a ResizeObserver-measured canvas so the chart draws in CSS pixels at any container shape. Prepares the chart to sit beside the order ticket without letterboxing; visually a no-op at today's full-width layout. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Drop the standalone "Your VIBE" panel and show the balance plus per-trade cost hint as a compact row inside the Conditional swap ticket, reclaiming a full-width section of vertical space. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Chart takes the flexible left column and the Conditional swap ticket a 300-380px right column, so orders can be staged against the live tape without scrolling. Submitted orders move to a full-width row directly below, page sections tighten from gap-10 to gap-6, and the redundant spot footnote goes away (the ticket already shows the live mid). Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/validity-ui-3-layout-split
branch
from
September 3, 2026 00:20
b832a0f to
a5626e1
Compare
haardikk21
approved these changes
Sep 3, 2026
Base automatically changed from
brianbland/validity-ui-2-ticket-balance
to
main
September 3, 2026 15:58
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 3/9 of the Validity demo UI rework — the core layout change.
lg:grid-cols-[minmax(0,1fr)_minmax(300px,380px)]), so orders can be staged and submitted against the live tape without scrolling. Belowlgthey stack chart-first as before.gap-10togap-6, and the spot footnote goes away (the ticket already shows the live mid).Generated with Claude Code