feat(vibenet): drive the Validity offset with a slider - #134
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
✅ Heimdall Review Status
|
BrianBland
force-pushed
the
brianbland/validity-ui-5-json-copy
branch
from
September 3, 2026 00:20
c93c93e to
9253bd4
Compare
BrianBland
force-pushed
the
brianbland/validity-ui-6-offset-slider
branch
from
September 3, 2026 00:20
1c6d795 to
7b79ffd
Compare
haardikk21
previously approved these changes
Sep 3, 2026
BrianBland
dismissed
haardikk21’s stale review
September 3, 2026 16:30
The merge-base changed after approval.
BrianBland
force-pushed
the
brianbland/validity-ui-6-offset-slider
branch
from
September 3, 2026 16:36
3402c08 to
9fb279b
Compare
Add a ui/Slider primitive (styled native range input with clickable labeled marks) and replace the fixed offset chips in the order ticket with a 0-5% slider in 0.1% steps, with the signed offset shown beside the section label. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
The thumb center travels from half its width to width minus half, while marks were placed at the raw track percentage, so they drifted apart toward the ends. Position marks with the same thumb-center geometry and center every label on its stop. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Co-authored-by: Claude <noreply@anthropic.com>
…on (#136) Co-authored-by: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/validity-ui-6-offset-slider
branch
from
September 3, 2026 20:05
69c2fb4 to
8bb0e48
Compare
haardikk21
approved these changes
Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parts 6-10 of the Validity demo UI rework.
Adds a
ui/Sliderprimitive (styled native range input with clickable labeled marks — first slider in the design system) and replaces the fixed offset chips (0/0.5/1/2/5%) in the order ticket with a 0–5% slider in 0.1% steps. Marks sit at even 1% intervals since the old chip values space unevenly on a linear track; the signed offset shows beside the section label.Generated with Claude Code