fix(vibenet): fill Validity orders already inside their price condition - #136
Open
BrianBland wants to merge 1 commit into
Open
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Collaborator
🟡 Heimdall Review Status
|
BrianBland
force-pushed
the
brianbland/validity-ui-8-fill-anchor
branch
from
September 2, 2026 20:48
f374dfc to
d1dc856
Compare
A buy priced above the mid (or a sell below it) used to anchor its reserve box at the target point alone, so the pool state never matched and the order quietly expired. Stretch the box along the hyperbola to the current point whenever the condition is already satisfied, keeping every corner within the named price bound, so those orders fill immediately instead. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/validity-ui-8-fill-anchor
branch
from
September 3, 2026 00:20
d1dc856 to
b18d481
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 8 of the Validity demo UI rework.
A buy priced above the mid (or a sell below it) used to anchor its four-predicate reserve box at the target point alone, so the pool state never matched and the order quietly expired — e.g. buy at ≤$1 with the mid at $0.07.
rectangleForTargetnow takes the current price and stretches the box along the hyperbola to the current point whenever the condition is already satisfied, so those orders fill immediately. Every box corner still respects the named price bound, and the resting-side box is byte-identical to before (covered by new tests).Generated with Claude Code