fix(vibenet): keep the Validity chart zoomed to the tape - #139
Merged
BrianBland merged 2 commits intoSep 3, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
BrianBland
force-pushed
the
brianbland/validity-ui-10-chart-zoom
branch
from
September 2, 2026 20:48
e39c51c to
7d5a895
Compare
BrianBland
force-pushed
the
brianbland/validity-ui-9-delay
branch
from
September 2, 2026 20:48
5ef1db0 to
215240f
Compare
BrianBland
force-pushed
the
brianbland/validity-ui-10-chart-zoom
branch
from
September 3, 2026 00:20
7d5a895 to
fb95c7c
Compare
Collaborator
🟡 Heimdall Review Status
|
haardikk21
approved these changes
Sep 3, 2026
BrianBland
added this pull request to the merge queue
Sep 3, 2026
BrianBland
removed this pull request from the merge queue due to a manual request
Sep 3, 2026
A not-before block predicate (block_number >=) joins the expiry bound: pick Off/5s/15s in a Delay chip row beside Expiry, with delay forced shorter than expiry and both under the 8130 envelope in concurrent mode. Annotations explain the lower bound, the review modal shows the start time, and delayed orders carry delaySeconds/minBlock through storage and the Submitted list. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
One order with a far-away target used to stretch the y-domain for its whole life and beyond: the domain included every fill's target price forever, even after the fill scrolled out of the window. Extract the domain math into domainBounds: the tape always fits, in-window fill prices and near-mid levels still show, but anything beyond 15% of the last price expands the view only while its order row is hovered. Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
BrianBland
force-pushed
the
brianbland/validity-ui-10-chart-zoom
branch
from
September 3, 2026 16:36
fb95c7c to
80bc639
Compare
BrianBland
force-pushed
the
brianbland/validity-ui-9-delay
branch
from
September 3, 2026 16:36
6572f86 to
99fdc6f
Compare
Base automatically changed from
brianbland/validity-ui-9-delay
to
brianbland/validity-ui-6-offset-slider
September 3, 2026 16:37
BrianBland
merged commit Sep 3, 2026
69c2fb4
into
brianbland/validity-ui-6-offset-slider
9 of 10 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part 10 of the Validity demo UI rework.
Placing an order with a far-away target (say $1 against a $0.07 mid) permanently zoomed the chart out: the y-domain included every resting level and every fill's target price unconditionally — even fills that had scrolled out of the 3-minute window. The domain math moves into an exported
domainBoundshelper with the rule: the tape always fits, in-window fill prices and levels within 15% of the last price still show, and anything farther expands the view only while its order row is hovered. Unit tests pin the hover/window/near-band behavior.Generated with Claude Code