fix: keep older-blocks pagination in shadow delta view - #142
Open
jowparks wants to merge 1 commit into
Open
Conversation
The shadow-delta branch hardcoded nextCursor: null, so "Older blocks →" disappeared whenever shadow delta was enabled. Derive the cursor from the oldest shadow block on a full page (via the API's exclusive `before` param) and thread the URL cursor through the shadow fetch so paging works.
Collaborator
✅ Heimdall Review Status
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jowparks
marked this pull request as ready for review
September 2, 2026 23:06
wbj-cb
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shadow-delta branch hardcoded
nextCursor: null, so the "Older blocks →" button vanished whenever shadow delta was enabled. Derive the cursor from the oldest shadow block on a full page and thread the URL cursor through the shadow fetch so pagination works in both views.Screenshots: not included — the affected route (
/internal-explorer/blockswith Show shadow Δ) is internal-only and requires a liveTIPS_*_SHADOW_METRICS_URLbackend that isn't available locally. Behavior is locked by a unit test on the newnextShadowCursorhelper instead.