Skip to content

fix(vibenet): always show the Conditional Swaps market view - #153

Open
BrianBland wants to merge 1 commit into
mainfrom
vibenet-validity-always-show-market
Open

fix(vibenet): always show the Conditional Swaps market view#153
BrianBland wants to merge 1 commit into
mainfrom
vibenet-validity-always-show-market

Conversation

@BrianBland

@BrianBland BrianBland commented Sep 3, 2026

Copy link
Copy Markdown
Contributor

Summary

  • The Conditional Swaps demo would sometimes show a "deploy pool / top up account" fallback view instead of the candles and order system.
  • Pool deployment and seeding is handled entirely by Vibenet infra now, so the demo no longer needs a client-side deploy/top-up branch — it always renders the market view.
  • Removed the now-dead fund/top-up code path and unused imports (Button, CopyableValue, formatEther, VibenetApiError) that only served that branch.

Screenshots

Verified locally: loading /vibenet/demos/validity/conditional-swaps now renders the candles + order ticket view directly (no deploy/top-up fallback). Screenshot not yet attached — will add if needed.

Test plan

  • npx tsc --noEmit — passes with no new errors.
  • npx eslint app/vibenet/demos/validity/ValidityDemo.tsx — same 6 pre-existing warnings, no new issues.
  • Ran the dev server and manually loaded /vibenet/demos/validity/conditional-swaps, created an account, and confirmed the candles + order ticket view renders directly.

Pool deployment is handled by Vibenet infra, so the demo no longer
needs a client-side "deploy pool / top up account" fallback view.
Removes that branch (and now-dead fund/top-up code) so the candles
and order system always render.

Co-Authored-By: Claude <noreply@anthropic.com>
@cb-heimdall

Copy link
Copy Markdown
Collaborator

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel

vercel Bot commented Sep 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
omni-ui Ready Ready Preview Sep 3, 2026 9:22pm UTC

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants